fix(dell): support extended HTTP boot option names#102
Merged
williampnvidia merged 1 commit intoJul 13, 2026
Merged
Conversation
Signed-off-by: Josh P <williamp@nvidia.com>
poroh
approved these changes
Jul 13, 2026
Author
|
Additional note regarding this PR: |
williampnvidia
added a commit
to NVIDIA/infra-controller
that referenced
this pull request
Jul 13, 2026
## Summary - bump libredfish from v0.44.18 to v0.44.19 - include Dell HTTP boot-option compatibility for both the legacy exact display name and the suffix added by newer firmware Upstream fix: NVIDIA/libredfish#102 Issue: NVIDIA/libredfish#101 ## Testing - `cargo metadata --locked --no-deps --format-version 1` - `cargo check --locked -p carbide-redfish` - `cargo check --locked -p carbide-redfish -p carbide-machine-controller -p carbide-api-core` (Linux) - `cargo make --no-workspace clippy-flow` (Linux) Signed-off-by: Josh P <williamp@nvidia.com>
10 tasks
nv-dmendoza
pushed a commit
to NVIDIA/infra-controller
that referenced
this pull request
Jul 13, 2026
Backport of #3442 to `release/v2.0`. Newer Dell firmware appends interface details to HTTP boot-option display names. libredfish v0.44.19 preserves the legacy exact-name match while also accepting the suffix used by newer firmware, allowing SetBootOrder to work with both firmware generations. `release/v2.0` previously pinned libredfish v0.44.16, so this backport advances it directly to v0.44.19. This also includes the changes from v0.44.17 and v0.44.18. Because v0.44.18 introduced `RedfishVendor::VeraRubin`, this PR also cherry-picks the compatibility handling from #3074 required to keep the release branch compiling. ## Related issues - Mainline dependency PR: #3442 - VeraRubin compatibility PR: #3074 - libredfish fix: NVIDIA/libredfish#102 - libredfish issue: NVIDIA/libredfish#101 ## Type of Change - [ ] **Add** - New feature or capability - [ ] **Change** - Changes in existing functionality - [x] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Breaking Changes - [ ] **This PR contains breaking changes** ## Testing - [x] Unit tests added/updated in the upstream libredfish fix - [ ] Integration tests added/updated - [ ] Manual testing performed - [ ] No testing required Validated on Linux against this backport branch: - `cargo check --locked -p carbide-redfish -p carbide-site-explorer` - focused Clippy for `carbide-redfish` and `carbide-site-explorer` - `cargo make --no-workspace clippy-flow` ## Additional Notes This PR contains two backported mainline commits: - `bec9dfe7c` — bump libredfish to v0.44.19 - `366947aef` — handle the VeraRubin vendor variant introduced by v0.44.18 Release Management should perform the merge. --------- Signed-off-by: Josh P <williamp@nvidia.com> Co-authored-by: hakhondzadeh <hakhondzadeh@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
" - "-delimited adapter/MAC/protocol suffixmachine_setup_status,set_boot_order_dpu_first, andis_boot_order_setupPartition 1matchingPartition 10Testing
cargo fmt --checkcargo clippy --locked --all-targets --all-features --workspace -- -D warningscargo buildcargo test --locked -- --test-threads=1test_dellintegration testtest_dell_multi_dpuintegration testFixes #101.
Related: #93. This is a draft fallback for the existing fix; only one implementation should be merged.